Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-140009: Optimize dict object by replacing PyTuple_Pack with PyTuple_FromArray
Summary
This PR replaces
PyTuple_PackwithPyTuple_FromArrayinObjects/dictobject.cfor creating small tuples (size 2).PyTuple_FromArrayis more efficient thanPyTuple_Packbecause it avoids the overhead of variadic arguments (va_args) processing by taking a pointer to a pre-allocated array ofPyObject*.Changes
PyTuple_Pack(2, Py_None, Py_None)withPyTuple_FromArrayusing a stack-allocated array.PyTuple_Pack(2, key, val2)withPyTuple_FromArray.Performance Impact
This is part of a general effort to optimize small tuple creation across the codebase. Replacing
PyTuple_PackwithPyTuple_FromArrayfor small, fixed-size tuples reduces call overhead.